Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

most_discriminating_terms no longer available #361

Open
quillan86 opened this issue Jul 1, 2022 · 2 comments
Open

most_discriminating_terms no longer available #361

quillan86 opened this issue Jul 1, 2022 · 2 comments

Comments

@quillan86
Copy link

steps to reproduce

I've previously used most_discriminating_terms function before but it seems to be commented out. It's necessary for my current role so far because I have a series of documents labeleld with a certain theme relative to a larger series of comments and I want to see what are the most discriminating terms in that document, but it seems like the code has been commented out.

expected vs. actual behavior

Tried importing textacy.extract.utils.most_discriminating_terms - not availble - code seems to be commented out

possible solution?

Reinclude this function

context

See above

environment

  • operating system: macOS
  • python version: 3.9
  • spacy version: 3.3.1
  • textacy version: 0.11.1
@quillan86 quillan86 added the bug label Jul 1, 2022
@bdewilde
Copy link
Collaborator

Hi @quillan86 , I removed — well, "hid" — that function a while ago because I could no longer vouch for or maintain it. I'm interested in reintroducing the functionality, in some form, back into textacy, but I haven't had much bandwidth for non-trivial to-dos. Just checking: Is this something you'd be comfortable hacking on? If not, you're totally welcome to copy-paste the code and make use of it internally as you see fit until I'm able to work on a suitable successor.

@bdewilde bdewilde added enhancement and removed bug labels Jul 25, 2022
@KalyanKumarPichuka
Copy link

Hey @bdewilde, Kindly let me know if I can work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants