fix: manually load font file or fonts dirs when use resvg-go #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelroses
reviewed
Apr 19, 2024
| switch runtime.GOOS { | ||
| case "windows": | ||
| DefaultFontsDirectories = []string{filepath.Join(os.Getenv("windir"), "Fonts")} | ||
| case "linux": |
There was a problem hiding this comment.
why not make this (the linux case) the default case then it should also be able to handle BSD systems too (at least in theory)
There was a problem hiding this comment.
if librsvg was installed, it won't meet this case.it easy for linux / BSD systems user to install librsvg
There was a problem hiding this comment.
I wonder if it would be better to do this at build time, rather than runtime? I.e. have font_linux.go, font_darwin.go, font_windows.go files, with the //go:build directives.
|
Thank you for this PR, it's very much appreciated ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #80