-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard-coded default repos #2771
Comments
@mhauru : This is certainly a test dataset included with Augur. We could possibly remove them, however my concern is that people starting up augur for the first time may not then know how to begin. |
Maybe they could be moved to configuration files outside of the main source code? Then by default a new instance of Augur would be configured with some repos, but severing that link and starting a "bare" instance would be as simple as changing the configuration files. |
Several source files have hard-coded in them the default repos to get data for, that I assume are used for testing purposes. This makes it hard to start my own instance of Augur that would not download data for these repos immediately as it starts, but rather wait for me to tell it which repos I'm interested in.
I'm not sure I found all instances of this, but here are a few places where the example repos are hard-coded:
augur/augur/application/schema/augur_full.sql
Line 4689 in a786ac5
augur/augur/application/schema/alembic/versions/legacy/80.3-sample-data.sql
Line 1075 in a786ac5
augur/docker/database/augur-new-schema.sql
Line 5814 in a786ac5
https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/augur/application/schema/repo_load_sample.csv
There may also be other hard-coded test/example cases, that aren't repos, that would probably be better kept in configuration files or as a part of the test suite. I spotted this one about contributors, but there may be others I missed.
augur/augur/application/schema/augur_full.sql
Line 4360 in a786ac5
The text was updated successfully, but these errors were encountered: