Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number of transformed files in codemod is double #1788

Open
3 tasks
yangwooseong opened this issue Dec 13, 2023 · 1 comment
Open
3 tasks

The number of transformed files in codemod is double #1788

yangwooseong opened this issue Dec 13, 2023 · 1 comment
Labels
bug Issues related to anything that isn't working

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented Dec 13, 2023

Summary

bezier-codemod 을 실행 결과에서 transformed files 의 수가 2배입니다.

image

(실제로 IDE 상에서 변경된 파일은 7개)

Reproduction process

const sourceFiles = project.addSourceFilesAtPaths(filePath)

바로 아래에서 로그를 찍어보면 filePath 에 해당하는 파일이 2번 배열에 들어가고 있어서 왜 그렇게 되는지를 봐야합니다.

사실 변경된 파일은 IDE로 쉽게 파악할 수 있기 때문에 몇 줄이 바뀌었는지를 알려주는게 더 좋을 것 같기도 합니다.

Version of bezier-react

0.4.0 (bezier-codemod)

Browser

No response

Operating system

  • macOS
  • Windows
  • Linux

Additonal Information

No response

@yangwooseong yangwooseong added the bug Issues related to anything that isn't working label Dec 13, 2023
@yangwooseong
Copy link
Collaborator Author

yangwooseong commented Jan 18, 2024

git 으로 추적되지 않는 파일중에서 변경이 일어난 경우가 있는지 확인 필요. 정확히 보려면 codemod 에서 파일 경로를 로그로 뱉는 로직추가하고 테스트 해야합니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to anything that isn't working
Projects
Status: 📌 Backlog
Development

No branches or pull requests

1 participant