Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retry failed PRs when queuing a high priority merge #263

Open
musicismyalibi opened this issue May 14, 2024 · 0 comments · May be fixed by #264
Open

Do not retry failed PRs when queuing a high priority merge #263

musicismyalibi opened this issue May 14, 2024 · 0 comments · May be fixed by #264

Comments

@musicismyalibi
Copy link

Currently, when a PR with high priority is queued, hoff will set the status of all integrated PRs to NotIntegrated. This, however, means that also failed PRs are also retried in this case. We should however only set PRs that are part of the merge train to NotIntegrated. This is only the PRs that are not failed or failed speculatively behind another PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not retry failed PRs in case of a high priority merge channable/hoff
1 participant
@musicismyalibi