New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker_threads in node.js report supportsColor false #97
Comments
Ehhh depends. I've not yet used worker threads, so I'm not 100% sure, but if their stdio handles map to TTY handles they should probably report isatty==1. Might be worth seeing if node has an issue open for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In worker threads, supports-color is unable to automatically detect color support.
It looks like the stream type in worker threads is
WritableWorkerStdio
which returnsisTTY
false so the check at:supports-color/index.js
Line 57 in 14a0e6f
stream.constructor.name === 'WritableWorkerStdio'
) then supportsColor returns correct information and color output does work. I'm not sure if that's the best fix or whether it even should be fixed.The text was updated successfully, but these errors were encountered: