Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum CLI Version check in the backend #796

Open
Tracked by #792
migmartri opened this issue May 17, 2024 · 1 comment
Open
Tracked by #792

minimum CLI Version check in the backend #796

migmartri opened this issue May 17, 2024 · 1 comment

Comments

@migmartri
Copy link
Member

migmartri commented May 17, 2024

The CLI and backend are rapidly evolving and currently there is no check to make sure CLI/Controlplane are compatible.

This is problematic since for example @jp-gouin ran into the following issue

- attestation.workflow.organization: value length must be at least 1 characters [string.min_len]

which was related to using a version of the CLI (0.83.0) that was not sending the required organization information in the attestation, requirement that was added in 0.87.

@jiparis
Copy link
Member

jiparis commented May 20, 2024

Implementation:

  • Add a minumunVersion to the /infoz enpoint response
  • Block CLI command only when there is a requirement in the backend (the case described in this task)

Another useful feature would be to add the used CLI version and digest to the local crafting state, so that these issues can be easily debugged. We would use this metadata in the render phase when doing att push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants