Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controlplane) do not allow updating name for most resources #680

Open
1 of 3 tasks
migmartri opened this issue Apr 22, 2024 · 0 comments
Open
1 of 3 tasks

chore(controlplane) do not allow updating name for most resources #680

migmartri opened this issue Apr 22, 2024 · 0 comments

Comments

@migmartri
Copy link
Member

migmartri commented Apr 22, 2024

names are currently primed to become identifiers that the user could use for the interaction with the controlplane instead of uuids.

We've already done most of the grunt work of setting such constraints i.e #663 #662, so next we should make sure names can not be updated.

This is something we've done already for contracts as part of this effort (note that this patch also includes updating by ID, which is out of the scope for now) #674

The changes require

  • update the ent schema to remove the setter on update
  • update the data and biz layers to not to accept name anymore
  • deprecate the protobuf property at the API layer

Tasks

  1. component/backend
    javirln
  2. component/backend
  3. component/backend
@migmartri migmartri changed the title do not allow updating name for cas-backends do not allow updating name for most resources Apr 22, 2024
@migmartri migmartri changed the title do not allow updating name for most resources chore(controlplane) do not allow updating name for most resources Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant