-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid SpringAddonsOidcProperties breaks native image #213
Comments
Thanks for reporting and investigating. There is no good reason for being incompatible with native images. Would you kindly give a try to the latest SNAPSHOT? I added the missing |
Sadly I am not able to build the repository so I cannot get the latest snapshot version (or maybe you're publishing those somewhere and I missed it?). Anyway, thank you for the fast resolution! |
Why that? it should be no more complicated than: git clone https://github.com/ch4mpy/spring-addons.git
cd spring-addons
sh ./mvnw install Once |
You can give a try to the |
Build issue solved.. my Maven installation was broken + screwed local config, day to day I am using Gradle so I've never noticed that :). Let me test the release then. |
@ch4mpy looks like everything is fine. Scenarios I've tested: JVM, native, extended docker native. In comparison to 7.6.13 it looks like there is only one thing that stopped working - I didn't investigate that because it might be again my local problem but it looks like IntelliJ stopped sensing the properties, with 7.6.13 it was working for |
Hello!
At first - thank you for the great work, brilliant repository :).
I didn't find a single note that
spring-addons-starter-oidc
should work fine in spring boot native images but as for now - for very basic case (token validation) it works almost fine so I've decided to report this bug - if you are not focusing on native images then feel free to close this ticket.BUG DESCRIPTION:
It looks like
SpringAddonsOidcProperties
is missingNestedConfigurationProperty
annotation onresourceserver
andclient
fields which causes issues in native image (no values). While it works perfectly fine for map/list types it doesn't work for any nested classes, that's whyops
field is totally fine.Source:
https://docs.spring.io/spring-boot/reference/native-image/advanced-topics.html#native-image.advanced.nested-configuration-properties
EXPECTED BEHAVIOR:
All fields in
SpringAddonsOidcProperties
are properly populated in spring boot native image.WORKAROUND:
For anyone who's looking for a simple workaround, this is how I solved the issue. It basically overrides default
SecurityFilterChain
bean defined by spring-addons:The text was updated successfully, but these errors were encountered: