Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Convert buttons used as links to <a> #575

Open
meissadia opened this issue May 23, 2024 · 0 comments
Open

[Accessibility] Convert buttons used as links to <a> #575

meissadia opened this issue May 23, 2024 · 0 comments
Assignees
@meissadia
Labels
post-mvp to be done after MVP deadline

Comments

@meissadia
Copy link
Collaborator

No description provided.

@meissadia meissadia self-assigned this May 23, 2024
@meissadia meissadia mentioned this issue May 23, 2024
Merged
@meissadia meissadia changed the title [Accessibility] Swap buttons used as links to <a> [Accessibility] Convert buttons used as links to <a> May 24, 2024
meissadia added a commit that referenced this issue Jun 6, 2024
@meissadia @billhimmelsbach
[Warnings/Errors] Design and accessibility improvements (#576)
46b3fea 
Close #568 

## Changes
- [Accessibility] Fix labelling issue in DSR Table/Pagination 
  - Dependent upon cfpb/design-system-react#356
- `Upload a new file` now a secondary button ([should be a link but I
couldn't get the styling overrides to play nice with one
another](#575))
- Update primary button label: `Download Report (CSV)`
- Remove green header border on Filing pages

## Screenshots
|Change|Screenshot|
|---|---|
|Button label (Warnings)|<img width="739" alt="Screenshot 2024-05-31 at
4 04 11 PM"
src="https://github.com/cfpb/sbl-frontend/assets/2592907/be87effb-1174-446a-89e8-44433b0a1c71">|
|Button label (Errors)|<img width="767" alt="Screenshot 2024-05-31 at 4
09 02 PM"
src="https://github.com/cfpb/sbl-frontend/assets/2592907/a5b4b6d1-f4c7-4be5-8ada-5f9d596026ea">|
|Remove green header border on filing|<img width="1230" alt="Screenshot
2024-06-03 at 9 54 54 AM"
src="https://github.com/cfpb/sbl-frontend/assets/2592907/e404f67b-3ff6-46a6-825f-fab60e574260">|
|Accessibility for pagination: input's `for` label aligns with table
id|<img width="974" alt="Screenshot 2024-06-03 at 9 53 03 AM"
src="https://github.com/cfpb/sbl-frontend/assets/2592907/35732b11-95ac-4627-a12e-00331896848b">|

---------

Co-authored-by: Bill Himmelsbach <[email protected]>
@meissadia meissadia added the post-mvp to be done after MVP deadline label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
post-mvp to be done after MVP deadline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meissadia