Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unit Tests #1312

Open
1 of 3 tasks
meissadia opened this issue Jan 18, 2022 · 3 comments
Open
1 of 3 tasks

Fix Unit Tests #1312

meissadia opened this issue Jan 18, 2022 · 3 comments
Assignees
@meissadia
Labels
Backlog Testing

Comments

@meissadia
Copy link
Contributor

meissadia commented Jan 18, 2022 •
edited

  • Find missing /test-resources from old UI repo
  • Work through tests failing due to outdated UI/API
  • Work through other missing files

Having these unit tests working will add another layer of assurance that changes aren't breaking the app.
@meissadia meissadia created this issue from a note in Sprint 104 FE (In progress) Jan 18, 2022
@meissadia meissadia self-assigned this Jan 18, 2022
@meissadia meissadia moved this from In progress to To do in Sprint 104 FE Jan 24, 2022
@meissadia meissadia changed the title [Explore] Get existing unit tests running Fix Unit Tests Jan 24, 2022
@meissadia
Copy link
Contributor Author

How it started
before-adding-react-preset

How it's going
Screen Shot 2022-01-24 at 9 55 38 AM

The more I fix, the more I find that are broken. We've made some great progress and will continue chipping away at this task, but moving it back to TODO for now.

@meissadia
Copy link
Contributor Author

Thoughts on Jest

  • Great for rapid feedback (runs in seconds as opposed to minutes like Cypress)
  • Complex to write (Mocking deeply nested structures, mocking appropriate functions)
  • Labor intensive to maintain (4 days of work so far and still a lot to fix)

Next steps

  • Synchronize usage of centralize mocks for consistency and maintainability
    • Always create mocks in the root/mocks folders
    • Create fixture generators?
      • We need this structure, generator fills-in the details...
  • Run unit tests in CI?
    • Block merge on failures?

Be more dilligent in operating on Container/Consumer pattern

@meissadia meissadia removed this from To do in Sprint 104 FE Jan 25, 2022
@meissadia
Copy link
Contributor Author

jest-deprecation-warnings

@Michaeldremy Michaeldremy added this to To do in Sprint 139 FE Jan 9, 2024
@Michaeldremy Michaeldremy removed this from To do in Sprint 139 FE Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
Backlog Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meissadia @Michaeldremy