Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expandable facet pattern #1292

Open
anselmbradford opened this issue Sep 13, 2021 · 4 comments
Open

Add expandable facet pattern #1292

anselmbradford opened this issue Sep 13, 2021 · 4 comments

Comments

@anselmbradford
Copy link
Member

https://www.consumerfinance.gov/consumer-tools/educator-tools/youth-financial-education/teach/activities/ has some sidebar expandable patterns that we don't capture in the design system. This is requiring some customizations in cfpb/consumerfinance.gov#6660

@anselmbradford anselmbradford changed the title Add additional expandable patterns Add additional expandable patterns? Sep 14, 2021
@sonnakim
Copy link
Member

There are also some (simpler) sidebar expandable patterns on iRegs and the prepaid database

@anselmbradford
Copy link
Member Author

There are also some (simpler) sidebar expandable patterns on iRegs and the prepaid database

Mmm yes regs does its own customizing https://github.com/cfpb/consumerfinance.gov/blob/main/cfgov/unprocessed/apps/regulations3k/css/reg-search.less#L34-L62

These similar patterns seem to be more of an argument to include the patterns in the DS.

@sonnakim sonnakim changed the title Add additional expandable patterns? Add sidebar expandable patterns? Aug 30, 2022
@anselmbradford anselmbradford changed the title Add sidebar expandable patterns? Add expandable facet pattern Apr 14, 2023
@anselmbradford
Copy link
Member Author

Work on this has been drafted up in #1628, however, TDP contains some unusual behavior where checking all children of a checkbox does not check the parent, and also options are dynamically added and removed in a seemingly buggy fashion.

@sonnakim sonnakim added this to Proposals for new Patterns in Patterns section Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Patterns section
  
Proposals for new Patterns
Development

No branches or pull requests

2 participants