Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Allow disabling of the heading styles #351

Open
billhimmelsbach opened this issue May 22, 2024 · 0 comments
Open

[Alert] Allow disabling of the heading styles #351

billhimmelsbach opened this issue May 22, 2024 · 0 comments
Assignees
@billhimmelsbach
Labels
post-mvp

Comments

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented May 22, 2024 •
edited

For Alerts, it would be great to add null as an option for headingLevel to disable the heading styles entirely.

Current behavior

  • you can set headingLevel to null for Alerts and it works in removing the heading styles, but Typescript complains: Type 'null' is not assignable to type 'HeadingLevel | undefined'.ts(2322)

Expected behavior

  • no Typescript errors, style is removed OR have a dedicated prop to remove styling
@billhimmelsbach billhimmelsbach self-assigned this May 22, 2024
@billhimmelsbach billhimmelsbach mentioned this issue May 22, 2024
Merged
billhimmelsbach added a commit to cfpb/sbl-frontend that referenced this issue May 28, 2024
@billhimmelsbach
feat(home): add beta banner, beta/legal alert (#560)
9ace385 
Adds the beta and legal alert to the unauthenticated home page.

Closes #559

## Changes

- adds a beta banner to all pages
- adds a beta/legal alert to the unauthenticated home page

## How to test this PR

1. Take a peek at the preview site
2. See if the banner and alert look like the designs
3. Test out the links in the alert
4. Make sure the banner appears correct on other pages in the app

## Design questions
- what should the subject line be for the `email our support staff` link
in the Alert box on the unauthenticated home page? I set it to `[BETA]
Home page: Questions or suggestions` for now @natalia-fitzgerald

## Screenshots
<img width="1884" alt="Screenshot 2024-05-21 at 11 32 50 PM"
src="https://github.com/cfpb/sbl-frontend/assets/19983248/5feffa85-e8ae-41fa-831a-57c776c0217d">



## Notes

- Future post-mvp related PRs
  - cfpb/design-system-react#352
  - cfpb/design-system-react#351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billhimmelsbach billhimmelsbach

Labels
post-mvp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billhimmelsbach