-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] What to do with it now that we have the DS Select implemented? #299
Comments
@meissadia In their Create a user profile pattern - address the USWDS recommends:
In the USWDS Create a user profile pattern - address pattern they use the Combo box component (instead of Select). The combo box component allows for filtering of data in the list when a user types in the field. The USWDS recommends this approach for when there are more than 15 choices in a drop-down list. The Combo box seems to have some overlap with our original "Dropdown" component. Although we we plan to use the standard Select as the state selector for MVP, we would like to hold on to this code in the event that we decide to create a Combo box component in the future. As a next step can we remove the "Dropdown" component from being visible in the Storybook library but save the code AND rename any references within that code to Combo box (instead of Dropdown)? If we do decide to pick up this code in the future there will still be quite a bit of styling work too capture our styling, however. This component never reached alignment with our styling. So, I do wonder whether we will want to save all of the code or just the part that adds the filtering functionality. We can discuss this next week if you'd prefer. |
A searchable select seems like a very useful component to have, and is already built, but we also don't want DSR consumers to get confused about which component is CFPB approved.
The text was updated successfully, but these errors were encountered: