Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accomodate for pages ending on a subpixel #117

Closed
wants to merge 1 commit into from
Closed

Accomodate for pages ending on a subpixel #117

wants to merge 1 commit into from

Conversation

pradyunsg
Copy link

@pradyunsg pradyunsg commented Jul 14, 2020 •
edited

Closes #116

Tested locally by directly modifying gumshoe.dist.js, and I can confirm it works. :)

@pradyunsg
Copy link
Author

I resisted the urge to simplify if (cond) { return true; } else { return false; } to return cond; -- is there a reason that pattern is followed throughout this codebase? o.O

@pradyunsg
Copy link
Author

pradyunsg commented Aug 31, 2020 •
edited

Nudge @cferdinandi!

@pradyunsg
Copy link
Author

Closing since @cferdinandi hasn't responded.

@pradyunsg pradyunsg closed this May 24, 2021
@pradyunsg pradyunsg deleted the patch-1 branch May 24, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isAtBottom isn't always correct on High DPI screens
1 participant
@pradyunsg