Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultValue should be named setValue, constantValue or simply value #14

Open
e3krisztian opened this issue Sep 5, 2013 · 0 comments
Open
Assignees

Comments

@e3krisztian
Copy link
Member

I have tried to solve #13 with adding defaultValue: '' to every not null field, but to my surprise it forced those fields to be null, even if there was data in the input for the field.

The name defaultValue implies to set the value when none was present - either the field is new (not in the input) OR the input field is there, but its value is NULL).

defaultValue is better named setValue, constantValue or simply value, as it is replacing the value unconditionally with the one specified.

Probably it is worth having both value and defaultValue as they are used in different situations.

@ghost ghost assigned bfaludi Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants