-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing variable naming in certbot/acme (private_key/privkey) #9941
Comments
The Notice how the Thus the variable name is actually quite correct and personally I don't find it really confusing in the preamble of |
While following along with the code in the crypto_util modules in acme and certbot, I was very confused by the references to the private key as the "Key to include in the CSR", since the public key is the one included in the CSR.
The reference to the private key continues until this call in acme.crypt_util
certbot/acme/acme/crypto_util.py
Line 272 in 873f979
Since it appears that the public key is the one being used, is it appropriate to refer to it as a public_key/pubkey rather than a private_key/privkey?
Will you accept a PR to change the variable name for purposes of clarity?
The text was updated successfully, but these errors were encountered: