-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add support to set future date as notBefore when requesting for certificate #7012
Comments
+1 this is an important feature we also want. |
Feel free to create a PR to add this feature. |
What is the best way to do this? I can think of two possible solution -
|
@inteon - do you have any suggestion on previous comment? |
I think a new field would be preferable if we want this feature to be widely supported. The logic itself will have to be implemented by each issuer individually, if we only add support to a very limited set of issuers, an annotation might be preferable. Altering the CertificateRequest API is not a decision to be taken without much thought. So, creating a design document first might be desirable. |
Is your feature request related to a problem? Please describe.
We want to issue a certificate with NotBefore set as some future time.
Describe the solution you'd like
Instead of using time.Now() here - https://github.com/cert-manager/cert-manager/blob/master/pkg/util/pki/certificatetemplate.go#L58, can you add support to set this as custom value?
/kind feature
The text was updated successfully, but these errors were encountered: