-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Hard-coded health path for readiness / liveness probes, yet ability to configure where it is exposed by Centrifugo #63
Comments
A potential fix:
|
Hello @vmcqgo - thanks for pointing. I think it's better to not use Sth like It's more configuration - two places instead of one, but feels more correct to me. Because Centrifugo's Surprisingly not-obvious thing :) |
Describe the bug
While you can configure the health handler path for Centrifugo through the config key
health_handler_prefix
, the liveness and readiness probes' paths are hard-coded as/health
in the deployment template:https://github.com/centrifugal/helm-charts/blob/master/charts/centrifugo/templates/deployment.yaml#L154-L165
Version of Helm and Kubernetes:
Helm Version:
Kubernetes Version:
Which version of the chart:
10.0.3
What happened:
Liveness / readiness probes are failing when a different health path is configured.
What you expected to happen:
Be able to configure the liveness and readiness probe paths or if the value for
health_handler_prefix
is not empty, use that value for probes path, too.How to reproduce it (as minimally and precisely as possible):
values.yaml
The text was updated successfully, but these errors were encountered: