Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiGatewayMetricFactory.metricTps and metricInvocationRate do not pass ".with(properties)" to underlying metricInvocationCount #434

Open
jackbnz-aws opened this issue Sep 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jackbnz-aws
Copy link

Version

5.0.0

Steps and/or minimal code example to reproduce

  1. Create a MetricFactory with a tps metric.
  2. use .with(properties); on the tps metric
  3. Observe that properties aren't included on the tps metric itself.

Relevant line of code:

Expected behavior

I would expect that properties are passed to the underlying metric. This functionality works on metrics that do not use the "toRate" method as the metric is directly returned.

For example, .with(properties) works correctly on metric4XXErrorCount:

Actual behavior

Properties are not passed to underlying TPS metric.

Other details

We are using this to show a widget for TPS, but need to specify the account. The account for the TPS metric we specify in the properties is not being used.

@jackbnz-aws jackbnz-aws added the bug Something isn't working label Sep 27, 2023
@jackbnz-aws jackbnz-aws changed the title ApiGatewayMetricFactory.metricTps and metricInvocationRate do not pass ".with" properties to underlying metricInvocationCount ApiGatewayMetricFactory.metricTps and metricInvocationRate do not pass ".with(properties)" to underlying metricInvocationCount Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant