Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat mechanisms #42

Open
Alphare opened this issue Jan 5, 2023 · 6 comments
Open

Add repeat mechanisms #42

Alphare opened this issue Jan 5, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Alphare
Copy link

Alphare commented Jan 5, 2023

I frequently listen to new albums on repeat to get a better feel for them, and sometimes individual songs that I really enjoy. Having a way of setting "repeat album" and "repeat song" would be very nice.

The issue I can see with "repeat album" would be that it could confuse the user intent of whether they're asking to replay the whole media player history (if other things were played before), or just the current album/playlist. Not sure if you simply want a third repeat mode. :)

What do you think?

@ccgauche
Copy link
Owner

ccgauche commented Jan 5, 2023

What I can do:

  • Add a shortcut to clean the history and maybe one to only keep the current song (equivalent for loop this title mode)
  • Place the history in the queue when the queue is empty (loops all musics in history)
  • So no need for a special repeat mechanism

@ccgauche ccgauche added the enhancement New feature or request label Jan 5, 2023
@ccgauche ccgauche self-assigned this Jan 5, 2023
@Alphare
Copy link
Author

Alphare commented Jan 6, 2023

I feel like this is more context-dependent and less obvious from a UX perspective than having repeat modes.

With repeat mode you can have:

  • a shortcut for each repeat mode without having to think about your history
  • the easy ability to undo what you just did
  • a clear icon that shows the repeat state (None/Playlist/Album/Track)
  • a simple configurable default behavior

Honestly it's also how basically all music players do it, so it's not really taking much risk. :)

@Rustmilian
Copy link
Contributor

Rustmilian commented Feb 19, 2024

a clear icon that shows the repeat state (None/Playlist/Album/Track)

what icon are you thinking of?

maybe something like these? ↺ ⟲

@ccgauche
Copy link
Owner

I think I'm just going to add a loop icon before the song title on the seeking bar. Or on the playlist title. With a shortcut like L to switch between looping modes

@Rustmilian
Copy link
Contributor

Rustmilian commented Feb 20, 2024

I think I'm just going to add a loop icon before the song title on the seeking bar. Or on the playlist title. With a shortcut like L to switch between looping modes

That's actually the same thing I was thinking of too when I started brainstorming solutions for this yesterday, tho I'd put the icon after instead of before.
I think this solution is the best, most strait forward & simplest solution; which is perfect for this.

I'm still a little concerned about which loop icon you'll go with. I recommend going with a plain Unicode one and not an emoji to make sure it works well on all terminals.

@ccgauche
Copy link
Owner

I have lots of improvements to make before starting to add new features (aka Improve the underlying api to make it faster, simpler and more resistant to changes on youtube data structures (which happens quite often).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants