Wrong TAKES_/CONCAT_ARG for msvc options

[silverqx]

During my latest patches I noticed that many msvc related options have incorrectly defined TAKES_ARG and TAKES_CONCAT_ARG.

I checked all these options like TAKES_ARG can contain space between the option and option value, and TAKES_CONCAT_ARG can't contain space between. Then I verified this at msvc Compiler options listed.

And this is what I noted down:

/Fp /Yu (remove TAKES_ARG, space is not allowed)
/AI (OK, works with space even docs doesn't state it and syntax is as: /AIfile)
/FU (OK, docs doesn't specify, but Syntax is described as: /FU file)
/FI /external:I /Yc (OK)
/Tc /Tp (add TAKES_CONCAT_ARG, space is optional)

I also tested /Fp and /Yu options using the cl.exe and the compiler throws an error if there is a space between.

Did I miss something or am I right?

[silverqx]

This morning I took the job and tested all these compiler arguments with cl.exe, how they behave with and w/o space.

/Yc, /Yu, /Fp throws compiler error if there is space between.

/AI works with space even docs doesn't state it and syntax is as: /AIfile
/FU also works without space even docs doesn't state it.
/Tc /Tp works with and w/o space.

[silverqx]

Now I tested it also with clang-cl and it's important it behaves the same as cl.exe, one difference is that clang-cl doesn't support /FU and /AI options.

[silverqx]

I proposed PR for it.