Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul ANSI & Base16 Colours #1961

Open
justTOBBI opened this issue Mar 3, 2023 · 9 comments
Open

Overhaul ANSI & Base16 Colours #1961

justTOBBI opened this issue Mar 3, 2023 · 9 comments
Labels
meta Org-wide matters

Comments

@justTOBBI
Copy link
Member

A person on twitter pointed out, that the term colors are broken due to them not having a light variant. We need ctp 2.1 to have more term colors.
image

@nekowinston nekowinston transferred this issue from catppuccin/kitty Mar 3, 2023
@nekowinston nekowinston changed the title Term Color issue (not only kitty) Improve the terminal color spec Mar 3, 2023
@nekowinston nekowinston added the meta Org-wide matters label Mar 3, 2023
@backwardspy
Copy link
Member

i know @extremepayne was looking into this a little while back, where did you get to with it?

@nekowinston
Copy link
Contributor

Yeah, I've been complaining about this issue too since June last year. I think it's fair to say its a known issue, and something we want to address. It will impact other ports though, not just terminal emulators.

Ports that come to mind:

  • Every terminal emulator, of course
  • IDEs/code editors with a Terminal function (JetBrains/VSCode, etc.)
  • TUI/CLI without truecolor support
    • Newsboat
    • GitUI
    • mc

I'm pretty sure there are more CLI tools that lack truecolor support, but those 3 are the first that come to mind.

@extremepayne
Copy link

extremepayne commented Mar 8, 2023

i know @extremepayne was looking into this a little while back, where did you get to with it?

Sorry for missing this ping; got lost in my inbox. I do have a set of colors I decided to use and I recorded them all in my fork of the alacritty port (chosen because I find the config format readable; i don't actually use alacritty). I'll put the macchiato colors (commented) here.

    # Normal colors
    normal:
        black: "#494D64" # surface1
        red: "#ED8796" # red
        green: "#A6DA95" # green
        yellow: "#F5A97F" # peach
        blue: "#8AADF4" # blue
        magenta: "#C6A0F6" # muave
        cyan: "#8BD5CA" # teal
        white: "#B8C0E0" # subtext1

    # Bright colors
    bright:
        black: "#5B6078" # surface2
        red: "#EE99A0" # maroon
        green: "#ADD9A8" # green but bright
        yellow: "#EED49F" # yellow
        blue: "#7DC4E4" # sapphire
        magenta: "#F5BDE6" # pink
        cyan: "#91D7E3" # sky
        white: "#A5ADCB" # subtext0

This hits most of the colors and keeps to the names they are given as part of the sixteen. It's missing rosewater, flamingo, and lavender, and it has a modified green simply because ctp has more reddish-purple and fewer green colors than the ANSI 16. Y'all would know better than me which colors are important to represent, I chose the ones I thought looked best. I'm also not certain if I've chosen the right direction for which ones are "bright" (peach and mauve certainly have more impact than yellow and pink, imo, so should those be bright?). But overall I think the pairings make sense and bring some differentiation to the terminal. I've been using this for a couple weeks and think it works great.

Edit: I should probably mention that the styleguide currently has peach and rosewater as "extended colors" for terminals that let you set more than 16 colors. I would recommend swapping peach for flamingo or lavender, were my choices to be adopted. I'm not sure how many terminals actually support that feature nor how many TUI/CLI attempt to take advantage of it but my guess is very few so I'm not sure how much it matters.

@MrDowntempo
Copy link

Is this something Base24 could fix? Which is a variant of Base16 color theme designer which adds 8 more colors for ANSI compliance.

@justTOBBI
Copy link
Member Author

@MrDowntempo thanks for the suggestion. It looks like it could very well fit our purpose. Looking into it, do you, by any chance, know what file format the custom theme, in this case catppuccin, has to be in?

@MrDowntempo
Copy link

@MrDowntempo thanks for the suggestion. It looks like it could very well fit our purpose. Looking into it, do you, by any chance, know what file format the custom theme, in this case catppuccin, has to be in?

I am not 100% sure, but I thiiiiiiiiink it should be compatible with the Base16 format you already have available:
https://github.com/catppuccin/base16

@justTOBBI
Copy link
Member Author

Maybe someone looking for a meaningful contribution to the Hacktoberfest could set its eyes on this?
Should I change the title to say HACKTOBERFEST: [title]?

@nekowinston
Copy link
Contributor

Maybe someone looking for a meaningful contribution to the Hacktoberfest could set its eyes on this? Should I change the title to say HACKTOBERFEST: [title]?

Since this impacts more than two dozen ports, I don't think this is up for grabs for Hacktoberfest. It's on our radar for the next update of the Catppuccin palette.

@justTOBBI
Copy link
Member Author

image
I experimented with terminal.sexy and got some pretty decent results when I light up the colours by ~10 points (Click on the colour and then subtract 10 from the S value)

Let me know how you feel about this :)

@sgoudham sgoudham changed the title Improve the terminal color spec Overhaul ANSI & Base16 Colours Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Org-wide matters
Projects
None yet
Development

No branches or pull requests

5 participants