Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashing or closing the app while sending an invoice can lead to lose of ecash! #286

Open
mariaa144 opened this issue Dec 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working priority: high high priority task

Comments

@mariaa144
Copy link

mariaa144 commented Dec 16, 2023

Describe the bug
App crashing or closing the app while sending an invoice can lead to lose of ecash!

To Reproduce
Steps to reproduce the behavior:

  1. Initiate a invoice send
  2. After eNuts is waiting for the mint to send the invoice, quickly close the eNuts application
  3. Open eNuts and notice there is nothing in the history to indicate an invoice was in progress
  4. Check you proofs and notice 1 or more proofs have been deleted!
  5. Now notice your balance is lower than it was before trying to send the invoice but there is nothing in history to indicate a transaction

Expected behavior
At no point should lose of ecash be possible due to closing the app or an app crash. Closing during sending an invoice should either cancel the invoice payment of try to continue where it left off during the invoice sending process.

Screenshots

Cut out personal section but you can still see the issue with closing the app at the wrong time.

recording_20231216_163450-cut-merged-1702765249629.mp4

Smartphone (please complete the following information):

  • Device: Pixel 6a
  • OS: GraphineOS
  • version 0.2.1 of eNuts
@KKA11010
Copy link
Collaborator

HI @mariaa144 ,

Thank you for reporting this issue. The app does not delete any proofs (ecash). The proofs used to pay an invoice are marked as spent during the lightning payment and in your case, the problem is a frontend thing because there is no pending history entries and therefore the proofs used for the payment are not visible anymore.

If you check the proofs after closing the app during the LN payment, it may seem like the proofs are deleted, but they are actually stored in a "usedProofs" database. All this is currently not accessible to the user.

Sorry for the inconvenience and I hope to find time to improve this UX asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high high priority task
Projects
None yet
Development

No branches or pull requests

2 participants