Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The codepoints of 📦️ seems not correct? #1615

Open
5 tasks done
loerise opened this issue Oct 26, 2023 · 3 comments
Open
5 tasks done

The codepoints of 📦️ seems not correct? #1615

loerise opened this issue Oct 26, 2023 · 3 comments
Labels
help-wanted Issues that you can pick up to collaborate with the project.

Comments

@loerise
Copy link

loerise commented Oct 26, 2023

Describe the bug

As emojipedia said, The codepoints of 📦️ should be U+1F4E6, but the codepoints of 📦️ in gitmojis is U+1F4E6U+FE0F.

When I use commitlint-config-gitmoji to lint my commit and use this emoji, it will report a error:

📦 is not in the correct gitmoji list, please check the emoji code on https://gitmoji.dev/. [start-with-gitmoji]

Reproduction

📦️ is copied from https://gitmoji.dev
📦 is copied from https://emojipedia.org/package

Open the Chrome DevTools, type "📦️" === "📦" in console and the result is false.
Or search on https://codepoints.net/

System Info

System:
  OS: macOS 13.4
  CPU: (8) arm64 Apple M1
  Memory: 188.17 MB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.13.0 - ~/.nvs/default/bin/node
  Yarn: 3.5.0 - ~/.nvs/default/bin/yarn
  npm: 9.5.0 - ~/.nvs/default/bin/npm
  pnpm: 8.9.2 - ~/Library/pnpm/pnpm
  Watchman: 2023.09.04.00 - /opt/homebrew/bin/watchman
Browsers:
  Chrome: 118.0.5993.117
  Safari: 16.5

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@vhoyer
Copy link
Collaborator

vhoyer commented Oct 27, 2023

yeah, well, the codepoint in emojipedia is shorter, so I guess it's wise that we'd prefer this one, I vote we change, but I'm also not completely aware of what are the impacts of changing this

@connorjs
Copy link
Contributor

I use Rocket app for Mac and :package (📦) gives me emojipedia version. This matches the Mac’s built-in emoji picker (CTRL+CMD+SPACE). I do not use CLI tools or assisted, so I’ve always been using this one (I type it myself with Rocket).

I also vote for changing (assuming I understood the issue correctly), but maybe tools like commitlint-config-gitmoji need to allow both.

@carloscuesta
Copy link
Owner

Sounds reasonable to me, let's change it! 🙏🏼

Feel free to open a PR 🖖🏼

@vhoyer vhoyer added the help-wanted Issues that you can pick up to collaborate with the project. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Issues that you can pick up to collaborate with the project.
Projects
None yet
Development

No branches or pull requests

4 participants