Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔙 for Backwards compatibility #1432

Open
4 tasks done
shankari opened this issue Apr 24, 2023 · 7 comments
Open
4 tasks done

🔙 for Backwards compatibility #1432

shankari opened this issue Apr 24, 2023 · 7 comments
Labels
emoji Gitmoji proposals. needs-feedback Needs more feedback from the community

Comments

@shankari
Copy link

shankari commented Apr 24, 2023

Emoji symbol

🔙

Emoji code

:back:

Emoji description

Code that adds backwards compatibility

Describe the use case of your emoji

Code that is used for backwards compatibility/live migration of online systems.

  • e.g. if the data format was originally {"foo": "bar"} but we want to change it to {"foo1": "bar"}
    so we write temporary code of the type
if "foo" in object:
    object["foo1"] = "bar"
    del object["foo"]

Is this use case covered by an existing emoji?

No ❌

Does this emoji fall into the "how" or the "what" category?

  • This proposal do not describe "how" a commit was made, but does in fact describe "what" is the contents of the commit about.

Examples

e-mission/e-mission-server@3fc3762
e-mission/e-mission-server@1c3f128
e-mission/e-mission-phone@72db83c

Validations

@shankari shankari added the emoji Gitmoji proposals. label Apr 24, 2023
@shankari shankari changed the title Code for Backwards compatibility 🔙 Code for Backwards compatibility Apr 24, 2023
@shankari shankari changed the title 🔙 Code for Backwards compatibility 🔙 Code for Backwards compatibility Apr 24, 2023
@shankari shankari changed the title 🔙 Code for Backwards compatibility 🔙 for Backwards compatibility Apr 24, 2023
@shankari
Copy link
Author

I am open to other emoji suggestions; I just think that backwards compatibility is a category of changes that should be captured.

@vhoyer vhoyer added the needs-feedback Needs more feedback from the community label Apr 24, 2023
@Thanyanit-J
Copy link

Thanyanit-J commented Jul 10, 2023

How about 🔄 (arrows_counterclockwise) ?
The left arrow alone gives the impression quite similar to undo.

When we talk about backward compatibility, we think like:

  • old file can run in the new system
  • new system supports the old file

So 🔄 seems more clear to me.

@vhoyer
Copy link
Collaborator

vhoyer commented Jul 14, 2023

IMHO, backwards compatibility (bwc) should be included in the original commit that added the new syntax, but I can kinda see why one would want to have this if something was forgotten (but in this case I would use 🐛 because if the application needed to have bwc and we didn't add it before, it is a bug to me), or maybe even explicitly separate it to git revert it later...

Anyway, since the back arrow really does remind of the ⏪ emoji, what do you people think of using 🦖 or 🦕 (cuz it's a extinct API, get it? funny)

@Thanyanit-J
Copy link

Thanyanit-J commented Jul 15, 2023 via email

@shankari
Copy link
Author

shankari commented Jul 15, 2023

IMHO, backwards compatibility (bwc) should be included in the original commit that added the new syntax, but I can kinda see why one would want to have this if something was forgotten

I prefer to add the backwards compatibility as a separate commit because:

  • git commits are supposed to be small and self-contained
  • I can revert the backwards compatibility commit later (once we don't have old-format data any more)

Having said that, the dinosaur idea 🦕 (:sauropod:) sounds great!

@Chasmical
Copy link

I myself used 🧩 for this purpose, although it's more of a "general" compatibility, rather than backwards- specifically.

@carloscuesta
Copy link
Owner

I like the idea!

🦖 is just perfect for this proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emoji Gitmoji proposals. needs-feedback Needs more feedback from the community
Projects
None yet
Development

No branches or pull requests

5 participants