Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rustls (instead of OpenSSL) #1008

Open
orhun opened this issue Aug 18, 2023 · 4 comments
Open

Support rustls (instead of OpenSSL) #1008

orhun opened this issue Aug 18, 2023 · 4 comments

Comments

@orhun
Copy link
Contributor

orhun commented Aug 18, 2023

Hey! 馃惢

For the context, I'm coming here from shuttle-hq/shuttle#100

I don't know if it is possible to use rustls for cargo-generate but wanted to bring this issue to your attention.

Would it be feasible to support rustls?

@sassman
Copy link
Member

sassman commented Aug 18, 2023

Hey @orhun,

BTW very cool that you work now on shuttle!

Would it be feasible to support rustls?

The Question would be does git2 support rustls instead? Because cargo-generate pulls this very dependency to openssl from git2 as you can see here:

vendored-openssl = ["openssl/vendored", "git2/vendored-openssl"]

@orhun
Copy link
Contributor Author

orhun commented Aug 18, 2023

Hey Sven!

BTW very cool that you work now on shuttle!

Thank you! 馃殌馃殌馃殌

The Question would be does git2 support rustls instead?

Ah I see, then I need to go one layer deeper.

鉀忥笍 rust-lang/git2-rs#623

BTW are there plans to switch to gitoxide in the future?

@sassman
Copy link
Member

sassman commented Aug 18, 2023

For some features we use gitoxide already. E.g gitconfig parsing etc.

But I watch the progress on gitoxide and at some point I have high hopes to be able to switch over. So yes there are plans :)

@orhun
Copy link
Contributor Author

orhun commented Aug 18, 2023

Great news, so it is possible to get rid of OpenSSL in the feature, nice! 馃惢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants