Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom element issue #51

Open
imperator-maximus opened this issue Oct 28, 2021 · 4 comments
Open

custom element issue #51

imperator-maximus opened this issue Oct 28, 2021 · 4 comments

Comments

@imperator-maximus
Copy link

Hi,

I am getting:

npx sveld --json --markdown The 'tag' option is used when generating a custom element. Did you forget the 'customElement: true' compile option? .[..]/node_modules/rollup/dist/shared/rollup.js:158

yes it is a custom element and it works fine and it is defined with "true" in rollup.

@metonym
Copy link
Collaborator

metonym commented Oct 28, 2021

Currently, the CLI does not pass options to the Svelte rollup plugin: https://github.com/carbon-design-system/sveld/blob/main/src/cli.ts#L22

As a workaround, can you try using Rollup?

@imperator-maximus
Copy link
Author

imperator-maximus commented Oct 28, 2021

Thank you for quick reply!
Yes in rollup it works but how to I activate markdown and JSON there?
I have sveld({ markdown: true, json: true}), in rollup now

@metonym
Copy link
Collaborator

metonym commented Oct 28, 2021

Thank you for quick reply! Yes in rollup it works but how to I activate markdown and JSON there? I have sveld({ markdown: true, json: true}), in rollup now

Interesting, that should work.

This is the set-up of one of the integration tests, which generates markdown/JSON API metadata: https://github.com/carbon-design-system/sveld/blob/main/integration/single-export/rollup.config.js#L16

@imperator-maximus
Copy link
Author

It was my fault and I looked in wrong folder. It works fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants