fix(GuideBanner): include styles in index-with-carbon.scss
#5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
added
package: styles
matthewgallo
requested review from
ariellalgilmore and
IgnacioBecerra
and removed request for
a team
matthewgallo
changed the title
index-with-carbon.scss
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
devadula-nandan
approved these changes
May 28, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 28, 2024
6a6b57c
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5335
Includes the
GuideBannerin_index-with-carbon.scssso styles can be imported from@use '@carbon/ibm-products/css/index';as expected.What did you change?
How did you test and verify your work?
Ran build script from
packages/ibm-products-stylesand verified that the associated built files now include GuideBanner styles.