Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Deploy #83

Open
emily827 opened this issue Sep 24, 2018 · 4 comments
Open

Contribution: Deploy #83

emily827 opened this issue Sep 24, 2018 · 4 comments
Assignees

Comments

@emily827
Copy link

The name of the icon is "deploy". It's going to be used when deploying code. The following .zip has the svg and an image of what it looks like.
deploy.zip

@asudoh
Copy link
Contributor

asudoh commented Sep 25, 2018

Thank you for bringing this up @emily827! Let's see if how many other Carbon users want this icon, and if our (or brand) designers agrees that the icon fits well in Carbon ecosystem. Meanwhile, you can use your custom icon in carbon-components-react's <Icon> component, by using a JSON data from SVG (XML) with a conversion, as <Icon>'s icon prop. Data format examples can be found at https://unpkg.com/[email protected]/dist/carbon-icons.js. Thanks!

@chrisconnors-ibm
Copy link

Hi @emily827 - thanks for submitting this. There's a couple issues:
Color. use plain black fill - colors will be applied in code later.

Stroke weight: for 16x16 icons in this style, stroke weight should be 1px

Alignment: as possible, make sure strong v and h elements and end points are aligned to the grid.
Yes:
image
No:
image

Avoid fractional sizes:
Yes:
image

No:
image

You might find some of the execution guidance on http://design-system.stage1.mybluemix.net/your-product-on-ibm-cloud/service-providers/service-icon useful for additional clarification.

@conradennis
Copy link

a version of this icon that is compatible with the new IBM Design Language is available here: https://next.carbondesignsystem.com/guidelines/iconography/library in the sketch kit or as individual SVGs from the icon library

look for the "deploy-rules" icon. If that icon does not suit your need please resubmit your artwork redrawn at 32px on grid and we can continue the contribution process. more guidance on icon production can also be found here: https://www.ibm.com/design/language/elements/icons

@mjabbink
Copy link

@conradennis close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants