Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Colon for Bulk Edit #1996

Open
delasource opened this issue Jan 23, 2024 · 3 comments
Open

Support Colon for Bulk Edit #1996

delasource opened this issue Jan 23, 2024 · 3 comments

Comments

@delasource
Copy link

The Bulk Edit toggle on the "App Configs" page is broken since forever.

Adding text in Bulk-mode and then toggling back, all "invalid" parameters are removed. As i can tell, "invalid" are lines with a :, ; or multiple = signs.

Which is kinda buggy. Adding them in single-entry mode works and that is good. Example:

Twitch:ClientId=aaaaaaa

is a valid entry (working with a dotnet project), but is removed by caprover when added in bulk mode.

Please fix, thanks.

# uname -a && lsb_release -a && free -h
Linux app 5.10.0-26-amd64 #1 SMP Debian 5.10.197-1 (2023-09-29) x86_64 GNU/Linux
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 11 (bullseye)
Release:        11
Codename:       bullseye
               total        used        free      shared  buff/cache   available
Mem:            15Gi       8.5Gi       504Mi       371Mi       6.3Gi       6.2Gi
Swap:             0B          0B          0B

@githubsaturn
Copy link
Collaborator

Colons are non-standard values in bash AFAIK. You can try this in any bash environment.

image

@githubsaturn
Copy link
Collaborator

Also, just to confirm it's intentionally blocked by the upstream library:
motdotla/dotenv#460 (comment)

@githubsaturn githubsaturn changed the title Bulk Edit broken Support Colon for Bulk Edit Jan 24, 2024
@delasource
Copy link
Author

Adding values with colons in single-entry mode does work, so it is probably not that seriously of an "intentional block". Caprover should be consistent then; if blocking it in bulk mode then also block it in single-entry mode. (but i wish it would be the other way around)

i found out, that one can also use double underscores instead of colons for nesting appsettings in dotnet. That works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants