Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default branch to main #2125

Closed
wants to merge 1 commit into from
Closed

Set default branch to main #2125

wants to merge 1 commit into from

Conversation

scarroll32
Copy link

@scarroll32 scarroll32 commented Apr 4, 2023 •
edited

Summary

(Guidelines for creating a bug report are available
here: https://github.com/capistrano/capistrano/blob/master/DEVELOPMENT.md)

Set default branch to main. Probably a breaking change.

Closes #2114

Short checklist

  • Did you run bundle exec rubocop -a to fix linter issues?
  • If relevant, did you create a test?
  • Did you confirm that the RSpec tests pass?

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here.

Thanks for helping improve Capistrano!

@scarroll32
Copy link
Author

CI is not running for some reason.

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

@mattbrictson mattbrictson added the ⚠️ Breaking Introduces a backwards-incompatible change label Apr 22, 2023
@mattbrictson
Copy link
Member

CI is not running for some reason

Good catch! Thanks for bringing this to my attention. I'll see if I can get it working again.

In terms of this PR, unfortunately I don't think the timing is right for a breaking change such as this. I'll leave it open in case there is an opportunity in the future to do a major release with other breaking changes.

@mattbrictson
Copy link
Member

I believe CI is not working because this PR is based on an old version of the master branch. We recently switched CI platforms. If you pull from upstream and rebase this PR on the latest master, it should work.

@scarroll32 scarroll32 closed this by deleting the head repository May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⚠️ Breaking Introduces a backwards-incompatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default scm branch to "main"
2 participants
@scarroll32 @mattbrictson