Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cantools has no way to load frame of only one bus #646

Open
benuu opened this issue Feb 6, 2024 · 2 comments
Open

Cantools has no way to load frame of only one bus #646

benuu opened this issue Feb 6, 2024 · 2 comments

Comments

@benuu
Copy link

benuu commented Feb 6, 2024

Cantools.db.load_file right now loads all the frames of all the buses. No args in the load_file function to let the user load the frame of a specific bus.
When different buses have frames with the same ID, but different frame definitions, this can be a problem in the final messages returned by Cantools.db.load_file.

@andlaus
Copy link
Member

andlaus commented Feb 6, 2024

I suppose that fixing this would require a medium-sized overhaul of cantool's current data model, namely to store all message objects within their respective bus objects instead of directly putting them into the database. While this is IMO quite doable, it is quite a bit of work and has the potential for breakage. I'll be happy to accept pull requests for this, though.

@wargithub
Copy link

I suppose that fixing this would require a medium-sized overhaul of cantool's current data model, namely to store all message objects within their respective bus objects instead of directly putting them into the database. While this is IMO quite doable, it is quite a bit of work and has the potential for breakage. I'll be happy to accept pull requests for this, though.

we got the same problem while using arxml.
expecting your fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants