Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mux values starting with Alpha in ID fails to convert. #611

Open
guy-radford-sunswap opened this issue Sep 26, 2023 · 1 comment
Open

Mux values starting with Alpha in ID fails to convert. #611

guy-radford-sunswap opened this issue Sep 26, 2023 · 1 comment

Comments

@guy-radford-sunswap
Copy link
Contributor

guy-radford-sunswap commented Sep 26, 2023

When setting a value for a Mux, if the value starts with an alpha, cantools, throws an error:

SYM: "Invalid syntax at line 3878, column 30: "Mux=FATAL_BAD_FAULT_TYPE 0,8 >>!<<C0h""

This version fails, the Mux line ends with the value C0h

[EDR_EVENT_FATAL]
ID=127h // Fatal event notification
Len=5
Mux=FATAL_BAD_FAULT_TYPE 0,8 C0h
Var=Context unsigned 8,32 // Fatal event context

If we change the Mux value to 90h (starting with a number) the error is not thrown.

[EDR_EVENT_FATAL]
ID=127h // Fatal event notification
Len=5
Mux=FATAL_BAD_FAULT_TYPE 0,8 90h
Var=Context unsigned 8,32 // Fatal event context
@guy-radford-sunswap guy-radford-sunswap changed the title Mux values starting with Alpha fail to convert. Mux values starting with Alpha fails to convert. Sep 26, 2023
@guy-radford-sunswap guy-radford-sunswap changed the title Mux values starting with Alpha fails to convert. Mux values starting with Alpha in ID fails to convert. Sep 27, 2023
@swaldhoer
Copy link

swaldhoer commented Jan 24, 2024

This is basically the same problem as #458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants