Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@CurrentUser annotation, authenticated user controllers, Signin controller. #31

Open
a-korzhov opened this issue Apr 24, 2020 · 0 comments

Comments

@a-korzhov
Copy link

a-korzhov commented Apr 24, 2020

1.Could you tell me the reason of @currentuser annotation, if there is no logic implemented for that? It is like empty annotation that nothing changes?
2. Why you are autowiring AuthenticationManager to controllers? You could just add Authentication to arguments of controllers, where you need for authenticated users. And from that Authentication get user data.
3. And why you are creating redundunt login controller, if Spring Security provides that? You need just add filter method from "extends UsernamePasswordAuthenticationFilter" and override Authentication attemptAuthentication. There you are getting user and authenticate him with username and password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant