Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hosts not set when duplicating team event-type #15012

Merged
merged 6 commits into from
May 15, 2024
Merged

fix: hosts not set when duplicating team event-type #15012

merged 6 commits into from
May 15, 2024
+10 −0

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented May 13, 2024 •
edited

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented May 13, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@anikdhabal anikdhabal marked this pull request as ready for review May 13, 2024 19:50
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 13, 2024
@graphite-app graphite-app bot requested a review from a team May 13, 2024 19:50
@anikdhabal anikdhabal changed the title fix: hosts not net when duplicating team event-type fix: hosts not set when duplicating team event-type May 13, 2024
@dosubot dosubot bot added event-types area: event types, event-types 🐛 bug Something isn't working labels May 13, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions github-actions bot added the teams area: teams, round robin, collective, managed event-types label May 13, 2024
CarinaWolli
CarinaWolli approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 🙏

@CarinaWolli CarinaWolli enabled auto-merge (squash) May 14, 2024 13:36
@CarinaWolli CarinaWolli merged commit 90ce0f8 into calcom:main May 15, 2024
32 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync event-types area: event types, event-types teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-3693] Hosts not set when duplicating team event type
2 participants
@anikdhabal @CarinaWolli