Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Introduce a new class WebAppURL that extends URL #14982

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: Introduce a new class WebAppURL that extends URL #14982

wants to merge 5 commits into from
+12 −4

Conversation

anikdhabal
Copy link
Contributor

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 10, 2024
@graphite-app graphite-app bot requested a review from a team May 10, 2024 23:33
@vercel Vercel
Copy link

vercel bot commented May 10, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the ✨ feature New feature or request label May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@graphite-app Graphite App
Copy link

graphite-app bot commented May 10, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/10/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@utkershrajvenshi
Copy link
Contributor

Great work! Should other references of WEBAPP_URL also be refactored in this PR itself or a separate one?

@anikdhabal
Copy link
Contributor Author

Great work! Should other references of WEBAPP_URL also be refactored in this PR itself or a separate one?

No, will handle it in this Pr.

@github-actions github-actions bot added the Low priority Created by Linear-GitHub Sync label May 13, 2024
@keithwillcode keithwillcode added this to the v4.2 milestone May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 30, 2024
@github-actions github-actions bot removed the Stale label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request Low priority Created by Linear-GitHub Sync 💻 refactor
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3685] Introduce class WebAppURL that extends URL one
3 participants
@anikdhabal @utkershrajvenshi @keithwillcode