-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot specify empty properties when using DotNetBuild #4158
Comments
Thanks @Zulu-Inuoe for reporting. It makes sense to allow for empty string values set explicitly. Let us know if you'll submit a PR or if we should leave this up-for-grabs |
Hey @augustoproiete sorry for the delay - Yes I will take a look at this while I can and open up a PR either today or tomorrow. But I won't complain if somebody else gets it done before I do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Cake runner
Cake .NET Tool
Cake version
3.0.0
Operating system
Windows
Operating system architecture
64-Bit
CI Server
Jenkins
What are you seeing?
And I receive the error that
A property must have at least one non-empty value
In my build.cake file I have the following:
Looking at the source
https://github.com/cake-build/cake/blob/b55239f748f921edc303d644839183e9727e00a4/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs#LL58C1-L61C18
this is presumably intentional.
However, setting this property as empty is in fact desired. see
https://learn.microsoft.com/en-us/windows/uwp/packaging/auto-build-package-uwp-apps
Specifically:
Is there any reason why we cannot set empty properties? Note that this problem is not there when using the MSBuild tool, rather than DotNetBuild
Seems like an easy fix but it's odd this check is in there to begin with
What is expected?
That I build and end up with
/p:PackageCertificateThumbprint ""
Steps to Reproduce
Output log
No response
The text was updated successfully, but these errors were encountered: