Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling some category tabs #185

Open
in-plaintext opened this issue Dec 2, 2023 · 10 comments
Open

allow disabling some category tabs #185

in-plaintext opened this issue Dec 2, 2023 · 10 comments

Comments

@in-plaintext
Copy link

in-plaintext commented Dec 2, 2023

Required before filing an issue:

I am a:

[x ] Real user of Poet Assistant
[ ] Student or researcher
[ ] Reporting an issue found by a software analysis or automation tool
[ ] Other: Please explain

I never use the 'rhymer' and 'reader' features, in addition to 'favorites'. There's an entry in the Android share menu (without any title) for all 'rhymer','thesaurus' and 'dictionary' while the copied & shared text (Android 13+) appears to always be opened in 'reader'.

Since for instance Termux doesn't use the standard Android share menu, Poet Assistant can't practically be effectively used with the app. Words have to be copied manually to Poet Assistant.


Android 13 / LineageOS 20

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

I did a quick test on Android 13, and when I selected "rhymer" from the share menu, it opened in the rhymer tab. 🤔 Perhaps I didn't use the same steps you were using.

Before looking into this in more detail, could you please let me know which version of the app you're using? The "reader" tab was renamed to "composer" in version 1.28.0.

Thanks!

@in-plaintext
Copy link
Author

in-plaintext commented Dec 2, 2023

could you please let me know which version of the app you're using? The "reader" tab was renamed to "composer" in version 1.28.0.

I'm using the current 1.30.6: version, but copied the tab names from an online image search. I'm sorry.

I don't think I'm shown any names for the Poet Assistant share tiles (note the phone layout):

screenshot

the context menu (accessed via the three-dot "hamburger icon) doesn't have any either:

screenshot (had to be captured from a screen-recording)

@in-plaintext
Copy link
Author

while the copied & shared text (Android 13+) appears to always be opened in 'reader'.

Since for instance Termux doesn't use the standard Android share menu, Poet Assistant can't practically be effectively used with the app. Words have to be copied manually to Poet Assistant.

Some clarification for the Termux issue — the app has its own context menu ( via 'more...') and Poet Assistant only has one entry when sharing text, seemingly always defaulting to 'composer':

screen-20231202-145155.mp4

@in-plaintext
Copy link
Author

Nonetheless I'll leave the issue open, in my view it's worthwhile to have options for removing unwanted entries from the app and Android context menus.

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

the context menu (accessed via the three-dot "hamburger icon) doesn't have any either:

screenshot (had to be captured from a screen-recording)

Could you let me know what app this screenshot is from?

Looks like the menu works fine from Chrome:

poet-assistant-share.mp4

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

For info, this may not apply exactly to what you're looking for, but there is a setting to disable poet assistant tabs from appearing in the context menu (like when selecting text inside chrome). It applies to all tabs though, there's not a separate setting for each tab:

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

As for termux, I didn't try that app, but it's a different entry point into poet assistant: it's a "share" functionality. It's true, the share functionality currently only opens in the composer tab.

So if I can summarize the issues (of this ticket):

  • Context menu: some apps don't show the tab names, they show the app name "Poet Assistant" for each tab.
  • Context menu: poet assistant doesn't have a way to choose a subset of tabs to appear (it's currently all or nothing)
  • Share functionality: only supports the composer tab, would be nice to choose which tab.

@in-plaintext
Copy link
Author

Could you let me know what app this screenshot is from?

fennec_fdroid (a Firefox for Android fork)


Android 13 / LineageOS 20

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

For info, I've opened a PR in termux, so that it can show text processing apps (like poet assistant rhymer/thesaurus/dictionary, wikipedia, google translate...) from the text selection menu. termux/termux-app#3720

@caarmen
Copy link
Owner

caarmen commented Dec 2, 2023

Could you let me know what app this screenshot is from?

fennec_fdroid (a Firefox for Android fork)

Android 13 / LineageOS 20

Thanks! I opened an issue over there about the incorrect labels appearing: https://gitlab.com/relan/fennecbuild/-/issues/58

Looks like I found the line of the code with the bug, but opening a PR for that project is a bit overwhelming (the bug is in geckoview, which looks like a huge project with a complicated build system).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants