Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL Security Warning #307

Open
grempe opened this issue Dec 15, 2021 · 1 comment
Open

CodeQL Security Warning #307

grempe opened this issue Dec 15, 2021 · 1 comment
Labels
bug Something isn't working module:command command module

Comments

@grempe
Copy link

grempe commented Dec 15, 2021

The GitHub CodeQL security scanning tool is reporting a security issue in this lib for a repo where I include it as a dependency.

Incomplete string escaping or encoding
A string transformer that does not replace or escape all occurrences of a meta-character may be ineffective.

It seems to be referencing the code here:

A screenshot of the warning:

Screen Shot 2021-12-15 at 2 25 32 PM
.

@c4spar c4spar added bug Something isn't working module:command command module labels Jan 26, 2022
@c4spar
Copy link
Owner

c4spar commented Mar 16, 2022

@grempe sry for late reply!

Thx for the report. I'm aware that this code should be improved and does not work correctly in all cases.
But i think it's not a crytical security issue as this code is only used when the completions script from the completions command is used and the values passed to the script are come the cli author anyway.
It could become critical if the values passed to the command come from a third party library.

But i agree we should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:command command module
Projects
None yet
Development

No branches or pull requests

2 participants