-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy warnings #48
Labels
enhancement
New feature or request
Milestone
Comments
I found another one: That happens with small tables that only contain scalars or empty tables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DISCLAIMER: I'm using a non-default clippy configuration.
With that, I have to use the following block for the generated Rust code:
This request is a "nice-to-have", not a real issue. But as the
flatbuffers
crate generates quite outdated and "dirty" rust code, it would be a nice benefit ifbutte
could try to be as rust-2018-clean as possible. Either by adding the allow directives in the generated code or by generating it in the desired style.clippy::unreadable_literal
: this happens with very large default values, e.g.:Clippy would expect
1_000_000
. The FlatBuffers schema doesn't support this and converting the format would probably be an excessive step, but it could be a case for an[allow(clippy::unreadable_literal)]
in the generated code.clippy::empty_enum
: this happens with the offset enums, e.g.:clippy::unseparated_literal_suffix
: this is part of the vtable, e.g.:single_use_lifetimes
: This warning is a bit annoying since it generates too many false positives in perfectly valid code. So I should better fix my configuration ;-). Nevertheless, it appears in a number of places:The text was updated successfully, but these errors were encountered: