-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nest helper types to tidy up top-level namespace #241
Comments
pcantrell
changed the title
Nest helper types to clear top-level namespace
Nest helper types to tidy up top-level namespace
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Swift now allows generic types to have nested types. Several enums ended up at the top level of Siesta’s namespace only because the type they would ideally be nested inside didn’t previously allow that nesting:
InputTypeMismatchAction
should be a member ofResponseContentTransformer
.StandardTransformer
probably should be too.There may now be other types types where nesting would make sense. Explore those. (Ensure that deprecated typealias fix backward compatibility.)
Protocols still disallow most nested types, so some things will unfortunately have to remain at the top level:
ResourceEvent
can’t beResourceObserver.Event
.RequestChainAction
can’t beRequest.ChainAction
.The text was updated successfully, but these errors were encountered: