Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users when all moves could not be guessed #38

Open
4 tasks
busser opened this issue Nov 21, 2022 · 2 comments
Open
4 tasks

Guide users when all moves could not be guessed #38

busser opened this issue Nov 21, 2022 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@busser
Copy link
Owner

busser commented Nov 21, 2022

In some cases tfautomv cannot guess all moves that need to be made. For improved user experience, we could make the following changes:

  • Print a message when tfautomv could not guess a move for all resources
  • Print a message when rerunning tfautomv may yield more moves
  • Add a page to the docs that walks users through advanced usage (-show-analysis, -ignore, etc.)
  • Link to the page in the message
@busser busser self-assigned this Nov 21, 2022
@busser busser added this to the v0.6 milestone Nov 21, 2022
@busser busser added enhancement New feature or request good first issue Good for newcomers documentation Improvements or additions to documentation labels Nov 21, 2022
@nelg
Copy link
Contributor

nelg commented Nov 21, 2022

The first case I had, tfautomv could not guess.

I had a module, called by a for_each going over a list. I removed the loop calling the module and split it out into a number of calls to the same module without the loop. It didn't seem to be able to figure this out.

@busser
Copy link
Owner Author

busser commented May 18, 2023

As mentioned on Reddit by HourglassDev, we should print a message when rerunning may find more moves.

This is the case when tfautomv found at least one move but the plan still isn't empty.

Updated the list in the issue description accordingly.

@busser busser modified the milestones: v0.6, v0.7 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants