Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes caused when using lots of HTML + snippets #249

Open
ElianaTroper opened this issue May 23, 2019 · 2 comments
Open

Crashes caused when using lots of HTML + snippets #249

ElianaTroper opened this issue May 23, 2019 · 2 comments

Comments

@ElianaTroper
Copy link

ElianaTroper commented May 23, 2019

I am getting a crash consistently across files when using large chunks of HTML. When additional HTML is added via snippets, it causes a crash.

Example code before crash:

                                                Hi!
Helloworld.

Then when I add certain code via snippets, a crash is caused. Here is an example snippet that causes a crash (the crash is triggered when modifying the first highlighted portion of the snippet):

'.text.md':
  'Highlight and color text':
    'prefix': 'highlightcolor'
    'body': '<div style="background-color:${1:black};color:${2:white};${3:display:inline-block}">$4</div>

Typing out the same code or copy-pasting seems to cause no issue. I disabled all Markdown related packages when testing this besides this one.

@burodepeper
Copy link
Owner

burodepeper commented May 23, 2019

I've been able to replicate the issue

  • create a new document
  • add the text from op: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Hi!Helloworld.
  • trigger the snippet
  • type red where black is highlighted in the snippet

after the first two letters, re, Atom freezes for me, without any output in the console.

@burodepeper
Copy link
Owner

It seems to disable syntax highlighting

This isn't an issue. There's a limit on how many subsequent tokens are 'allowed' on a single line. I believe the default is 100. After that, syntax highlighting is disabled for better performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants