-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework permission methods #1399
Comments
This will be good to look at. I will look into it more later, but for now, I think...
I think definitely in the |
I agree with you. In the object oriented model we have:
This will most likely result in API breaking change as we will remove the methods from the gspread client. But the good point is: well keep the logic for permissions in a single location ! |
Overview
permissions methods are located in the client and in a the spreadsheet, this is not right, only 1 object should provide a single way to add/list/delete permission.
Details
The gspread client and the spreadsheet object allow a user to insert permissions, but only the client allows a user to list/remove a permission.
The spreadsheet object does not take the same kind of arguments as the gspread client does, this is confusing.
We should have a unified way of inserting/listing/deleting permissions.
This Issue is here to:
The text was updated successfully, but these errors were encountered: