Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow multisite config in docker autoconf #551

Open
Silur opened this issue Jul 4, 2023 · 2 comments
Open

[FEATURE] Allow multisite config in docker autoconf #551

Silur opened this issue Jul 4, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request v2

Comments

@Silur
Copy link

Silur commented Jul 4, 2023

Docker autoconf mode (as of 1.5.0) currently does not support assigning multisite config to the labels section. <ore precisely, the nginx config will pick the SERVER_NAME up but not the relevant bunkerweb.mysubdomain.example.com_AUTO_LETS_ENCRYPT etc entries

Currently if one container has multiple exposed ports that a reverse proxy has to separately attach in autoconf mode, we have to fire up two separate instances of this container.

It'd be if autoconf mode would also respect `-"bunkerweb.SERVER_NAME=app1.example.com app2.example.com" and then the relevant subdomain confs as seen in https://docs.bunkerweb.io/1.5.0/concepts/#multisite-mode

@Silur Silur added the enhancement New feature or request label Jul 4, 2023
@TheophileDiot
Copy link
Member

Hi @Silur, thank you for opening this issue. Did you consider using wildcards ?
By looking at the documentation about server names I also find out that you can use regex inside server names. Right now sadly regex for server names won't work in the version 1.5.0 because of the regex but in the next release you will be able to use them.

It's not recommended but you can try this out by compiling the staging branch.

@TheophileDiot TheophileDiot self-assigned this Jul 7, 2023
@fl0ppy-d1sk fl0ppy-d1sk added this to TODO in 1.6.X Aug 4, 2023
@fl0ppy-d1sk
Copy link
Member

fl0ppy-d1sk commented Aug 4, 2023

I think we should treat that special case in the next major release.

Here is what comes to my mind : add a special setting like AUTOCONF_MULTISITE=yes/no and if set to yes to a special service (as label) then we process the labels in multisite mode. The same way you describe @Silur but we need that switch in case someone wants to have multiple domains for the same service and don't want the multisite feature.

Anyway we also need to provide a way to add extra configs without containers (and with hot reload).

@fl0ppy-d1sk fl0ppy-d1sk removed this from TODO in 1.6.X Oct 16, 2023
@fl0ppy-d1sk fl0ppy-d1sk added the v2 label Oct 16, 2023
@fl0ppy-d1sk fl0ppy-d1sk self-assigned this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2
Projects
None yet
Development

No branches or pull requests

3 participants