Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minification #1428

Open
julianrubisch opened this issue Apr 11, 2024 · 2 comments
Open

CSS minification #1428

julianrubisch opened this issue Apr 11, 2024 · 2 comments

Comments

@julianrubisch
Copy link
Contributor

I was scrolling through the Lighthouse audit of my app when I noticed this:

image

Though it's not a ton, it's easily fixed by just adding --minify here: https://github.com/bullet-train-co/bullet_train/blob/main/package.json#L39-L40

I wonder if it's worth upstreaming this to the starter repo? "pretty printing" the CSS in the browser's devtools still makes it easily inspectable.

Or we could add an environment variable, e.g. MINIFY_CSS to switch it on/off?

@jagthedrummer
Copy link
Contributor

Oh, that's interesting. I do think we should figure out how to get --minify to be the default for production. Or maybe make it always the default and use an ENV var to skip minification? SKIP_MINIFY_CSS or something?

@julianrubisch
Copy link
Contributor Author

julianrubisch commented May 6, 2024

Yep. ~~Though to be honest, it seems the bulk of minification could be earned on the theme. ~~

Disregard, I misremembered that. I'll investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants