Repo link in README is not replaced

[newstler]

Some why this code doesn't change the repo in README.

[jagthedrummer]

I think this is related to the fact that we had some bad commits on main.

[jagthedrummer]

I just looked into this and I think it's a legit bug.

There's this line where we ask if you want to setup GitHub:

bullet_train/bin/configure

Line 188 in c73c9c8

skip_github = ask "Continue setting up with GitHub? [y/n]"

And then on the next line we test it like this:

bullet_train/bin/configure

Line 189 in c73c9c8

if skip_github.downcase[0] == "y"

But then further down the script we do some less specific tests, that don't really test what we want to be testing.

bullet_train/bin/configure

Line 269 in c73c9c8

unless skip_github

bullet_train/bin/configure

Line 283 in c73c9c8

if skip_github

[jagthedrummer]

Relatedly, it seems that we only even attempt to replace the repo URL if you did not choose to setup GitHub. Which seems less than ideal.

bullet_train/bin/configure

Lines 269 to 273 in c73c9c8

	unless skip_github
	original_repo_link = "https://github.com/bullet-train-co/bullet_train"
	new_repo_link = ask "What is the link to your repository? We will use this to enable the one-click deploy to Render button for your application."
	replace_in_file("README.example.md", original_repo_link, new_repo_link, /repo=#{original_repo_link}/)
	end

If you do setup GitHub we ask you for the ssh variant of the repo URL and not the https variant. But according to the render docs they need the https variant.

Set the value of repo to the full https:// URL for your Git repo.

I think maybe we should explicitly ask if you want to use Render. If you're planning to deploy to Heroku or literally any other deployment target it doesn't really do you any good to have a "deploy to Render" button on your README. In fact, it could really be counterproductive and send people down a dead end.

This is kind of related to the idea that we have too much stuff kind of haphazardly crammed into bin/configure. #1440