Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting defaultWhenFalse to False by default in util.Property #7505

Open
RaymondBakerIBM opened this issue Apr 9, 2024 · 0 comments

Comments

@RaymondBakerIBM
Copy link

RaymondBakerIBM commented Apr 9, 2024

When it is set True unintuitive behavior can occur such as

doStepIf=util.Property("test") == 0
becoming
doStepIf=(None == 0)
when the property test = 0

Basically change this line to have defaultWhenFalse=False
https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/properties.py#L810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant