Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current GitPoller misses merge commits #7494

Open
jasugun opened this issue Apr 2, 2024 · 0 comments
Open

Current GitPoller misses merge commits #7494

jasugun opened this issue Apr 2, 2024 · 0 comments

Comments

@jasugun
Copy link

jasugun commented Apr 2, 2024

Hi, the current git poller _git_commit_files lists no files for merge commits (with no conflicts)
This makes the poller totally miss these merge commits.
When merging diffrent branches, it has the potential to trigger scedulers based off wrong commits from other branches.

Is this on purpose or can I make a PR with a fix (I think adding -m to the git command would fix the issue) here?
https://github.com/buildbot/buildbot/blob/master/master/buildbot/changes/gitpoller.py#L354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant